core/state: deleted field in StateObject Copy() and unit test #1781
Conversation
| so0Restored := state.GetStateObject(stateobjaddr0) | ||
| so1Restored := state.GetStateObject(stateobjaddr1) | ||
| // non-deleted is equal (restored) | ||
| compareStateObjects(so0, so0Restored, t) |
There was a problem hiding this comment.
if !reflect.DeepEqual(so0, so0Restored) { ... } could also work.
There was a problem hiding this comment.
Right, though then it could be harder to see what's wrong given that these objects have quite a few fields. Especially storage fields would be tricky to see if just printing a deep version of the objects.
There was a problem hiding this comment.
Tried that but it prints 61 lines per state object which makes comparison a bit harder, especially if the test would later fail and one checks CI output.
There was a problem hiding this comment.
I'd personally prefer that to maintaining a 43-line function. But this is not a critical issue.
There was a problem hiding this comment.
There's a fatal flaw to this approach; adding new attributes will not be caught by this check. I'm adding an additional DeepEqual that tests the test and should fail if new flags have been added (and obviously not added to test)
There was a problem hiding this comment.
Actually DeepEqual doesn't work due to pointers. I'm set on fixing this however
|
👍 |
|
Having stared at it for 30min, I cannot think of anything this could break. 👍 |
core/state: deleted field in StateObject Copy() and unit test
core/state: deleted field in StateObject Copy() and unit test (cherry picked from commit 90f1fe0)
core/state: deleted field in StateObject Copy() and unit test (cherry picked from commit 90f1fe0)
* origin/release/1.1.0: cmd/geth: bump 1.1.3 Merge pull request #1781 from Gustav-Simonsson/state_object_copy
No description provided.