Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: use ChainHeadEvent subscription in the chain indexer #17826

Merged
merged 1 commit into from
Oct 3, 2018
Merged

core: use ChainHeadEvent subscription in the chain indexer #17826

merged 1 commit into from
Oct 3, 2018

Conversation

zsfelfoldi
Copy link
Contributor

This PR switches the indexer to follow ChainHeadEvent instead of ChainEvent.

karalabe
karalabe approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will test it along with the freezer to see what happens.

@karalabe karalabe added this to the 1.8.17 milestone Oct 3, 2018
@karalabe karalabe merged commit 9d06b2c into ethereum:master Oct 3, 2018
cpchainbot pushed a commit to CPChain/chain that referenced this pull request May 23, 2019
@jsyqrt
CHAIN-1106 security upgrade about chain_indexer.go from github.com/et…
941023a 
…hereum/go-ethereum ethereum/go-ethereum#17826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

@holiman holiman Awaiting requested review from holiman holiman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.17
Development

Successfully merging this pull request may close these issues.
2 participants
@zsfelfoldi @karalabe