Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: initial implementation of https://eips.ethereum.org/EIPS/eip-1884 #19572

Closed
wants to merge 1 commit into from

Conversation

holiman
Copy link
Contributor

@holiman holiman commented May 14, 2019

This PR implements https://eips.ethereum.org/EIPS/eip-1884 .
It adds 'Istanbul' as a new hard fork, but does not impement the full puppeth support -- we will need to know how parity and aleth defines it before we can fully add it there.
Potential TODO: refactor how we handle fork configurations, to make it

  1. More flexible, so we can more easily configure what eips goes into a particular named HF,
  2. More tightly coupled, so we don't risk missing a config/getter/setter in one place, or copy-paste with the wrong number

That should be in a separate PR, however.

@karalabe
Copy link
Member

This was superseded by #19743.

@karalabe karalabe closed this Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants