Homestead Release Candidate #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❗ Pull request against
Updated: Wed Feb 24 12:22:45 UTC 2016 |
obscuren
force-pushed
the
release/1.3.4
branch
from
cab3b0b
to
3d7c95f
Compare
Current coverage is
|
obscuren
force-pushed
the
release/1.3.4
branch
from
cf542ea
to
fbedb62
Compare
The s2 parameter was not actually written to the MAC.
Conflicts: p2p/discover/udp_test.go
Conflicts: p2p/rlpx.go
…han-buffer packets On Windows, UDPConn.ReadFrom returns an error for packets larger than the receive buffer. The error is not marked temporary, causing our loop to exit when the first oversized packet arrived. The fix is to treat this particular error as temporary. Fixes: ethereum#1579, ethereum#2087 Updates: ethereum#2082 Conflicts: p2p/discover/udp_test.go
…otocol changes * change gas cost for contract creating txs * invalidate signature with s value greater than secp256k1 N / 2 * OOG contract creation if not enough gas to store code * new difficulty adjustment algorithm * new DELEGATECALL op code Conflicts: core/vm/environment.go crypto/crypto.go crypto/secp256k1/secp256.go eth/api.go
* Removed some strange code that didn't apply state reverting properly * Refactored code setting from vm & state transition to the executioner * Updated tests Conflicts: common/registrar/ethreg/api.go core/tx_pool.go core/vm/jit_test.go
…or selfish mining Assuming the following scenario where a miner has 15% of all hashing power and the ability to exert a moderate control over the network to the point where if the attacker sees a message A, it can't stop A from propagating, but what it **can** do is send a message B and ensure that most nodes see B before A. The attacker can then selfish mine and augment selfish mining strategy by giving his own blocks an advantage. This change makes the time at which a block is received less relevant and so the level of control an attacker has over the network no longer makes a difference. This change changes the current td algorithm `B_td > C_td` to the new algorithm `B_td > C_td || B_td == C_td && rnd < 0.5`.
| // secp256k1 eliptic curve and an error if it failed deriving or upon an | ||
| // incorrect signature. | ||
| // | ||
| // FromFrantier uses the frontier consensus rules to determine whether the |
There was a problem hiding this comment.
Small typo on line 182, should be FromFrontier
Great work and congrats on the RC!
obscuren
force-pushed
the
release/1.3.4
branch
from
ecfc500
to
8d6d9e1
Compare
This commit increases the artificial gas floor to 4712388 (cherry picked from commit f954a8b)
When a block is queried for retrieval we should add a check whether the block falls within the frontier rules. If we'd always use `From` retrieving transaction might fail. This PR temporarily changes everything to `FromFrontier` (safe!). This is a backport of c616391
Fixes ethereum#2201 (cherry picked from commit 26e72b2)
Turns out we actually don't need it, USE_NUM_NONE works because we also set USE_FIELD_INV_BUILTIN. Conflicts: Makefile crypto/secp256k1/secp256.go
…ll part fetchers (cherry picked from commit 64ee576)
… and GPO to 20 shannon (cherry picked from commit ab92678)
(cherry picked from commit e22fd22c97b4f5d4af118dca3fb2cb6292a520a6) Conflicts: cmd/utils/flags.go
obscuren
force-pushed
the
release/1.3.4
branch
from
ec640de
to
61be63b
Compare
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The homestead release candidate
PLEASE NOTE: Block number is NOT final
This is a cherry picked release and include the PR listen on the 1.3.4 milestone