Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is no need to call ’IsLondon‘ twice #23333

Merged
merged 3 commits into from
Aug 9, 2021
Merged

There is no need to call ’IsLondon‘ twice #23333

merged 3 commits into from
Aug 9, 2021

Conversation

lxex
Copy link
Contributor

@lxex lxex commented Aug 5, 2021

There is no need to call ’IsLondon‘ twice, which may affect TPS

@lxex
There is no need to call ’IsLondon‘ twice
b32a0c6 
There is no need to call ’IsLondon‘ twice, which may affect TPS
holiman
holiman approved these changes Aug 7, 2021
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It won't make a dent on TPS, but it doesn't hurt either.

@lxex
Copy link
Contributor Author

lxex commented Aug 8, 2021

LGTM. It won't make a dent on TPS, but it doesn't hurt either.

thanks，I contribute fist time. I wish i could do more.

karalabe
karalabe reviewed Aug 9, 2021
View reviewed changes
core/state_transition.go Outdated Show resolved Hide resolved
@holiman holiman added this to the 1.10.7 milestone Aug 9, 2021
@holiman holiman merged commit d60cfd2 into ethereum:master Aug 9, 2021
@holiman
Copy link
Contributor

holiman commented Aug 9, 2021

Thanks!

sidhujag pushed a commit to sidhujag/go-ethereum that referenced this pull request Aug 15, 2021
@lxex
core: fix london-check to avoid duplication (ethereum#23333)
87c1f7d 
Co-authored-by: lxex <liuxmzc1@163.com>
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
@lxex @atif-konasl
core: fix london-check to avoid duplication (ethereum#23333)
8031284 
Co-authored-by: lxex <liuxmzc1@163.com>
This was referenced Sep 23, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe left review comments

@holiman holiman holiman approved these changes

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.7
Development

Successfully merging this pull request may close these issues.
3 participants
@lxex @holiman @karalabe