Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: check effective tip in txpool pricelimit validation #23855

Merged
merged 1 commit into from
Nov 8, 2021
Merged

core: check effective tip in txpool pricelimit validation #23855

merged 1 commit into from
Nov 8, 2021

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Nov 4, 2021

The price limit is supposed to exclude transactions with too low fee
amount. Before EIP-1559, it was sufficient to check the limit against
the gas price of the transaction. After 1559, it is more complicated
because the concept of 'transaction gas price' does not really exist.

When mining, the price limit is used to exclude transactions below a
certain effective fee amount. This change makes it apply the same check
earlier, in tx validation. Transactions below the specified fee amount
cannot enter the pool.

Fixes #23837

@fjl
core: check effective tip in txpool pricelimit validation
7a58fdc 
The price limit is supposed to exclude transactions with too low fee
amount. Before EIP-1559, it was sufficient to check the limit against
the gas price of the transaction. After 1559, it is more complicated
because the concept of 'transaction gas price' does not really exist.

When mining, the price limit is used to exclude transactions below a
certain effective fee amount. This change makes it apply the same check
earlier, in tx validation. Transactions below the specified fee amount
cannot enter the pool.

Fixes ethereum#23837
holiman
holiman approved these changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

karalabe
karalabe approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@karalabe
Copy link
Member

karalabe commented Nov 8, 2021

Question is whether we should merge this before or after release. Seems like a change that would be healthy to be on bootnodes/signers a while before going out into the wild.

@karalabe karalabe added this to the 1.10.13 milestone Nov 8, 2021
@karalabe karalabe merged commit 9489853 into ethereum:master Nov 8, 2021
sidhujag pushed a commit to syscoin/go-ethereum that referenced this pull request Nov 8, 2021
@fjl
core: check effective tip in txpool pricelimit validation (ethereum#2…
ba5f552 
…3855)

The price limit is supposed to exclude transactions with too low fee
amount. Before EIP-1559, it was sufficient to check the limit against
the gas price of the transaction. After 1559, it is more complicated
because the concept of 'transaction gas price' does not really exist.

When mining, the price limit is used to exclude transactions below a
certain effective fee amount. This change makes it apply the same check
earlier, in tx validation. Transactions below the specified fee amount
cannot enter the pool.

Fixes ethereum#23837
@Kzenox7 Kzenox7 mentioned this pull request Nov 27, 2021
Closed
This was referenced Dec 7, 2021
Closed
Merged
@ryanschneider ryanschneider mentioned this pull request Dec 9, 2021
Closed
This was referenced Sep 23, 2022
Closed
Merged
yongjun925 pushed a commit to DODOEX/go-ethereum that referenced this pull request Dec 3, 2022
@fjl @zzyalbert
core: check effective tip in txpool pricelimit validation (ethereum#2…
f5c9d9e 
…3855)

The price limit is supposed to exclude transactions with too low fee
amount. Before EIP-1559, it was sufficient to check the limit against
the gas price of the transaction. After 1559, it is more complicated
because the concept of 'transaction gas price' does not really exist.

When mining, the price limit is used to exclude transactions below a
certain effective fee amount. This change makes it apply the same check
earlier, in tx validation. Transactions below the specified fee amount
cannot enter the pool.

Fixes ethereum#23837
@gzliudan gzliudan mentioned this pull request May 17, 2024
Merged
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
e217eb7 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
73baab1 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
f62aa23 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
159669f 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
a0e6047 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
00213bb 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 10, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
ee213be 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
f6ccca3 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
0eb8e77 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
d52bbbf 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
ff8bfd7 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
70d55d0 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 21, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
8239fe5 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
86c960f 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
e4504c8 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
d2c026f 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
3ab5bf2 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
3a30de2 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
5bf9bf0 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 27, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
fc6a83c 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 9, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
d844cc8 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 17, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
fc9b735 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 18, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
71076fc 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
a5074a2 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
a873c75 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 29, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
c8ba08d 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 30, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
8cf5dc5 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
53bab5a 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
71282b1 
…3855)
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 1, 2024
@gzliudan
core: check effective tip in txpool pricelimit validation (ethereum#2…
6feb71e 
…3855)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

@holiman holiman holiman approved these changes

@hbahrami11 hbahrami11 hbahrami11 approved these changes

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.13
Development

Successfully merging this pull request may close these issues.

geth -pricelimit not very useful after EIP1559
4 participants
@fjl @karalabe @holiman @hbahrami11