eth/downloader: purge pre-merge sync code #29281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
jwasinger
commented
Mar 19, 2024
jwasinger
commented
Mar 22, 2024
jwasinger
commented
Mar 26, 2024
jwasinger
commented
Mar 26, 2024
fjl
reviewed
Apr 9, 2024
fjl
reviewed
Apr 9, 2024
| func TestFailedSyncProgress68Snap(t *testing.T) { testFailedSyncProgress(t, eth.ETH68, SnapSync) } | ||
| func TestFailedSyncProgress68Light(t *testing.T) { testFailedSyncProgress(t, eth.ETH68, LightSync) } | ||
|
|
||
| func testFailedSyncProgress(t *testing.T, protocol uint, mode SyncMode) { |
There was a problem hiding this comment.
I'm not sure how to adapt/replace this test case. Because the head is trusted, a faulty chain/peer cannot cause the sync cycle to fail.
jwasinger
force-pushed
the
downloader-post-merge-purge
branch
2 times, most recently
from
9173271
to
218008b
Compare
|
Whoops. There was one failing test that I had forgotten to fix. I've done that and rebased this. Should be okay to merge now. |
rjl493456442
approved these changes
Apr 23, 2024
jwasinger
force-pushed
the
downloader-post-merge-purge
branch
from
9a30230
to
1d6956a
Compare
jorgemmsilva
pushed a commit
to iotaledger/go-ethereum
that referenced
this pull request
Jun 17, 2024
This PR removes pre-merge sync logic from the downloader. Now-irrelevant tests are removed and others have been updated.
stwiname
pushed a commit
to subquery/data-node-go-ethereum
that referenced
this pull request
Sep 9, 2024
This PR removes pre-merge sync logic from the downloader. Now-irrelevant tests are removed and others have been updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes pre-merge sync logic from the downloader. Now-irrelevant tests are removed and others have been updated. Fork tests are currently failing due to the issue identified/addressed in #29358