Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify done goroutine way #29813

Closed
wants to merge 5 commits into from
Closed

Modify done goroutine way #29813

wants to merge 5 commits into from

Conversation

javaandfly
Copy link
Contributor

description

  • I think coroutine resources should be closed outside the function

@Halimao Halimao mentioned this pull request May 22, 2024
Closed
@fjl
Copy link
Contributor

fjl commented May 23, 2024

We will not apply this change because there is no immediate benefit to the codebase.

@fjl fjl closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mazzika1 Mazzika1 Mazzika1 approved these changes

@karalabe karalabe Awaiting requested review from karalabe karalabe is a code owner

@holiman holiman Awaiting requested review from holiman holiman is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javaandfly @fjl @Mazzika1