Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: BA.unpack -> BA.convert #45

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Performance: BA.unpack -> BA.convert #45

merged 1 commit into from
Sep 29, 2022

Conversation

arcz
Copy link
Collaborator

@arcz arcz commented Sep 29, 2022

Description

I was doing some profiling on Echidna and found BA.unpack to leak memory. This doesn't happen with BA.convert.

Checklist

  • tested locally
  • added automated tests
  • updated the docs
  • updated the changelog

@d-xo d-xo merged commit f424454 into ethereum:main Sep 29, 2022
@d-xo
Copy link
Collaborator

d-xo commented Sep 29, 2022

thanks!

@arcz arcz deleted the ba-convert branch January 10, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-xo d-xo d-xo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arcz @d-xo