Make Ethereum tests pass #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoep
reviewed
Oct 17, 2022
|
pushed a fix for an off by one error in |
d-xo
reviewed
Oct 18, 2022
Comment on lines
+150
to
+153
| ConcreteStore s -> mempty -- clearZeroStorage $ fromMaybe mempty $ Map.lookup (num addr) s | ||
| EmptyStore -> mempty | ||
| AbstractStore -> mempty -- error "AbstractStore, should this be handled?" | ||
| SStore {} -> mempty -- error "SStore, should this be handled?" |
There was a problem hiding this comment.
what needs to be done here? I think we can safely error out on any symbolic storage expressions here since VMTests should always be concrete...
Comment on lines
+155
to
+158
| {- | ||
| clearOrigStorage :: EVM.Contract -> EVM.Contract | ||
| clearOrigStorage = undefined | ||
| -} |
| @@ -114,72 +116,77 @@ checkExpectation diff x vm = do | |||
| return okState | |||
|
|
|||
| -- quotient account state by nullness | |||
| (~=) :: Map Addr EVM.Contract -> Map Addr EVM.Contract -> Bool | |||
| (~=) cs cs' = | |||
| (~=) :: Map Addr (EVM.Contract, Storage) -> Map Addr (EVM.Contract, Storage) -> Bool | |||
There was a problem hiding this comment.
Should we use the ContractWithStorage type here?
| clearOrigStorage :: EVM.Contract -> EVM.Contract | ||
| clearOrigStorage = undefined | ||
| -} | ||
|
|
||
| -- TODO: why is this needed? |
There was a problem hiding this comment.
good question hehe, any ideas? I'm not super familiar with the VMTest format...
Merged
|
Thanks again @arcz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #9
Checklist