This repository has been archived by the owner on Sep 5, 2020. It is now read-only.
Redo of PR 1348 - add SHA256 hashes for client binary downloads #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hiddentao, thanks for your PR! By analyzing the history of the files in this pull request, we identified @luclu, @alexvandesande and @frozeman to be potential reviewers. |
|
@hiddentao there seems to be some npm deps issue in the travis logs |
|
Looks like it did the shrinkwrap-thing again! |
# Conflicts: # npm-shrinkwrap.json
alexvandesande
approved these changes
Nov 6, 2016
|
superseded by #1392 |
frozeman
pushed a commit
that referenced
this pull request
Nov 7, 2016
* update client binaries pkg * redo of PR #1348 * work towards new client binary logic * updated package elemeents * Work towards client update checker, and asking user for permission to update. * change regex * change wording * fix npm-shrinkwrap.json * use even better regex (pun intended) * updated allowed regex
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@luclu As requested.