Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

Disabling dark theme #1362

Merged
merged 6 commits into from
Oct 28, 2016
Merged

Disabling dark theme #1362

merged 6 commits into from
Oct 28, 2016

Conversation

evertonfraga
Copy link
Member

In order to keep Mist interface always consistent and prevent visual glitches (#523, #702), we're dropping the dark theme, used on Linux.

@evertonfraga evertonfraga added this to the 0.8.8 milestone Oct 28, 2016
@evertonfraga evertonfraga self-assigned this Oct 28, 2016
@mention-bot
Copy link

@evertonfraga, thanks for your PR! By analyzing the history of the files in this pull request, we identified @frozeman and @alexvandesande to be potential reviewers.

@evertonfraga
Copy link
Member Author

Also fixed some blank spaces above the sidebar and dapp-url bar. Properly tested on ubuntu 64.

screen shot 2016-10-28 at 1 31 03 pm

screen shot 2016-10-28 at 1 31 21 pm

screen shot 2016-10-28 at 1 40 50 pm

@frozeman
Copy link
Contributor

otherwise very nice, thanks for the fast PR!

@@ -118,16 +105,6 @@ main {
left: @widthSideBar;
top: 0;
bottom: 0;

&.open-bar {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats that? Why is it removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

back in time when you focused on the url bar, a huge div unfolded, and blurred the active tab. as we don't have this unfolding section anymore, i did the clearance.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok super

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frozeman now in Mist repo at least 01 review is required in order to merge. if you approve the PR I can merge it right away.

Copy link
Contributor

@frozeman frozeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes good

@evertonfraga evertonfraga merged commit 4f49947 into develop Oct 28, 2016
@evertonfraga evertonfraga deleted the ev_disable_dark_theme branch October 28, 2016 19:39
@lock
Copy link

lock bot commented Mar 31, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Mar 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants