This repository has been archived by the owner on Sep 5, 2020. It is now read-only.
Moved preloder includes, checked for ipc vulnerabilities #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frozeman, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexvandesande and @hiddentao to be potential reviewers. |
luclu
approved these changes
Nov 4, 2016
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR i went over the places which could be dangerous exposing the IPC in the popup windows.
So far i have no better idea how to shield the ipc from the popupwindows.
I moved some preloader include files into the include folder.
Added some warning for the
--loglevel trace, as this logs also requests containing the password! And these logs are stored in log files. So developers who enable log level trace need to take extra caution.