update geth 1.5.2 download links

[luclu]

Change update URL to https://raw.githubusercontent.com/ethereum/mist/luclu_update-geth-1.5.2/clientBinaries.json to test.

Tested:

• linux64
• mac
• win64
• win32

[mention-bot]

@luclu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexvandesande and @hiddentao to be potential reviewers.

[frozeman]

@evertonfraga can you test the rest?

[frozeman]

If they only provide MD5, lets add a md5 check.

[luclu]

Copied from the chat:

Mah win isn’t working yet. While unpacking geth-windows-amd64-1.5.2-c8695209\\geth.exe it should extract geth.exe but instead creates a new folder called dows-amd64-1.5.2-c8695209.
The first missing characters geth-win have the same length as geth.exe. ;P

Hmm, this behaviour is caused by missing error handling at the unzip statement. unzip fails with this error on both windows zips:

Error: invalid signature: 0x80014

As a migration path we can upload new non-problematic zips to bintray/github.
Here is a basic script to trigger the error:

var fs = require('fs');
var unzip = require('unzip');

fs.createReadStream('geth-windows-386-1.5.2-c8695209.zip').pipe(unzip.Extract({ path: 'output' }));

Apperently this is a 2 years old issue. There also is a fork fixing it as the packing won’t receive update anymore: https://github.com/glebdmitriew/node-unzip-2 - this works.

[frozeman]

Why closing this? This PR is for updating the client binaries URLs.

[evertonfraga]

@frozeman this is automatic behavior from github. Ram merged the issue on ethereum-client-binaries, then GH thinks it has to be closed here.

[lock]

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.