Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

[cleanup] remove obsolete codesigning files #1445

Merged
merged 3 commits into from
Nov 22, 2016

Conversation

luclu
Copy link
Contributor

@luclu luclu commented Nov 21, 2016

No description provided.

@mention-bot
Copy link

@luclu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @frozeman to be a potential reviewer.

evertonfraga
evertonfraga previously approved these changes Nov 21, 2016
@frozeman
Copy link
Contributor

frozeman commented Nov 21, 2016

Why are they obsolete??
These are a work in progress and probably still necessary for a future proper signing. Until we don't have a proper signing, i would keep them, as they were my WIP on that front.

Proper signing means, we need to sign all elements including electron and other parts of the app.
Could you sign properly with the production =certificate yet, @luclu ?

@evertonfraga evertonfraga dismissed their stale review November 21, 2016 17:49

a WIP shouldn't be considered obsolete

@luclu
Copy link
Contributor Author

luclu commented Nov 21, 2016

The signing process in electron-builder differs from xcode. Those files are not needed as any necessary files will be auto-generated and restructured into the final .app.

@frozeman Code-Signing works with my developer certificate.

Also please note that the production certificate can only be used on the MacStore and will be auto-signed by Apple in the process. Please see MaintainingCertificates.

@frozeman
Copy link
Contributor

If the signing using electron builder works we can rid of these for now. We still have them in the hortatory if needed

@frozeman frozeman merged commit d828339 into develop Nov 22, 2016
@luclu luclu deleted the luclu_remove-old-codesigning branch November 22, 2016 16:26
@evertonfraga evertonfraga modified the milestone: 0.8.8 Dec 5, 2016
@lock
Copy link

lock bot commented Mar 31, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Mar 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants