Adds an opt out option to the node auto updater

[frozeman]

This adds an opt out option where it saves the skipped node version in a skippedNodeVersion.json file. As long as the current to be updated node version matches the entry in the file it wont ask for update, otherwise popup the question window, which shows details about the update node.

TODO: we need to add md5 hash verification to ethereum client binaries updater, which sits now at:
https://github.com/ethereum/ethereum-client-binaries

Please all make sure to test this extensively.

• This should involve, removing the clientBinaries.json from the mist data folder.
• changing the file clientBinaries.json a bit (change on version number etc.) to trigger a update request
• remove binaries and see if they update properly
• ideally remove your global geth instance too
• test the skipping, it will be stored in skippedNodeVersion.json in the mist data folder
• downgrade a version and test the successful upgrade process.
  etc..

You can use http-server npm package to start a server inside any folder. Start one in the mist folder so you can serve the clientBinaries.json by yourself and make changes to it to test.

You just need to then change the line 58, of the modules/clientBinaryManager.js, for testing

[mention-bot]

@frozeman, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexvandesande, @luclu and @hiddentao to be potential reviewers.

[luclu]

I created a PR for md5 checksums: ethereum/ethereum-client-binaries#6

[luclu]

Notes / TODO (ongoing):

• pressing "skip" on the initial startup (no downloaded nodes) will still download the binary
• pressing "check for Ethereum node updates" while no updates available won't give any feedback to user, "... (Last checked ${time} ago)" could be added to the menu-item after checked
• the popup looks neat!
• "md5" key/value not recognised
• Fabian still didn't install or configure eslint in his editor... dude... 🍤
• code is currently locked in on geth, should be client agnostic

[evertonfraga]

Still testing. some findings:

✅ From a clean install I managed to upgrade geth from 1.4.17 > 1.4.18 > 1.5.2 successfully.

⚠️ if Geth has no executable permissions, the splash gets stuck on that step. I know it's rather unlikely, but we can handle this better.

❌ If it's the first run (any nodes downloaded), the user will be prompted to "update". In case the user closes/skips the window, it cannot move forward, as they don't have any node. The user will only be able to start mist properly if it deletes skippedNodeVersion.json and accept the update request.

[alexvandesande]

Was about to make a PR to this PR but ended up committing the most important change (a9745a0) here.

Anyway, now both "update available window" have the same basic structure, removed some redundant code and language and standardized it to the look and feel of our windows and buttons:

[frozeman]

@evertonfraga for the first time thats an issue, true. will fix. (Tho, i thought this shouldn't happen, as the of line: https://github.com/ethereum/mist/blob/nodeDownloaderFix/modules/clientBinaryManager.js#L88)

But if you skipped update, you can click the main menu and click "check for node updates". This will erase the skippedVersion file and check for updates again.

@alexvandesande looks good. Please add a third button, skip for now. Or do we want to do this behaviour only if the user closed the update window?

[luclu]

@alexvandesande I feel like the URL would look better if not wrapped

[evertonfraga]

Well, I've ironed up my test environment and probably I've messed with some json file on the first tests — sorry for the false negative. Today i did an intensive batch of checks and everything worked properly.

• All the skips working OK.
• All updates worked OK.
• Force node update OK.
• skippedNodeVersion.json working OK.

I've been struggling to test on windows, though. For an undetected reason, I can't parse any json from remote server anymore. So got is not working, even on old Mist versions. Of course it's a problem of my setup, so maybe if @luclu could test on windows while I make this work again, I'd be glad.

[alexvandesande]

@luclu I increased the width 30px so it won't break like that 😜

[lock]

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.