Integrating electron-builder for better distributables building #972

hiddentao · 2016-07-15T07:47:39Z

This replaces electron-packager with electron-builder so that we can build distributables with installers for both Mist and the Wallet.

Creates installers for Windows, Mac and Linux (debian) 👊
Builds for 32-bit on all platforms where supported
Streamlined node download and unzipping process
Renames darwin to mac inside code and gulpfile because that's what electron-builder uses
Upon success, builds are placed into either dist_mist/release or dist_wallet/release depending on chosen app type (mist, wallet)

# Conflicts: # package.json

luclu · 2016-07-20T10:52:45Z

npm-shrinkwrap.json

@@ -1,7 +1,17 @@
 {
  "name": "Mist",
-  "version": "0.8.0",
+  "version": "0.8.1",


# Conflicts: # gulpfile.js

hiddentao · 2016-08-03T14:12:06Z

Got distributables building for all platforms, but when I try to install on Windows it comes up with a JS syntax error. I wasn't getting this before either. Need to figure it out.

frozeman · 2016-08-03T15:08:02Z

Are you making sure that when you rename darwin to mac, that files are properly catched, as the electron builder uses darwin and also the downloadable geth packages

hiddentao · 2016-08-03T15:10:13Z

I need to double-check everything obviously. But fairly sure that's all working now.

hiddentao · 2016-08-08T05:11:22Z

Finally this is ready for review!

alexvandesande · 2016-09-07T23:15:07Z

Tried running it but wasn't able to build anything:

(node:14282) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
You can select a platform like: --platform <mac|win|linux|all>
App type: mist
Mist version: 0.8.2
Electron version: 1.3.5
Selected platform: [ 'darwin' ]
[20:08:51] Using gulpfile ~/dev/mist/gulpfile.js
[20:08:51] Starting 'mist'...
[20:08:51] Starting 'set-variables-mist'...
[20:08:51] Finished 'set-variables-mist' after 352 μs
[20:08:51] Starting 'clean:dist'...
[20:08:51] Starting 'checkNodes'...
[20:08:51] Finished 'checkNodes' after 933 μs
[20:10:00] Finished 'clean:dist' after 1.15 min
[20:10:00] Starting 'copy-app-source-files'...
[20:10:00] Starting 'copy-node-folder-files'...
[20:10:02] Finished 'copy-app-source-files' after 1.98 s
[20:10:02] Starting 'copy-app-folder-files'...
cp: /Users/alex/dev/mist/node_modules/webdriverio/node_modules/.bin/supports-color: No such file or directory
Error symlinking node_modules
[20:12:19] 'copy-app-folder-files' errored after 2.28 min
[20:12:19] Error: cp: /Users/alex/dev/mist/node_modules/webdriverio/node_modules/.bin/supports-color: No such file or directory

    at formatError (/usr/local/lib/node_modules/gulp/bin/gulp.js:169:10)
    at Gulp.<anonymous> (/usr/local/lib/node_modules/gulp/bin/gulp.js:195:15)
    at emitOne (events.js:101:20)
    at Gulp.emit (events.js:188:7)
    at Gulp.Orchestrator._emitTaskDone (/Users/alex/dev/mist/node_modules/orchestrator/index.js:264:8)
    at /Users/alex/dev/mist/node_modules/orchestrator/index.js:275:23
    at finish (/Users/alex/dev/mist/node_modules/orchestrator/lib/runTask.js:21:8)
    at cb (/Users/alex/dev/mist/node_modules/orchestrator/lib/runTask.js:29:3)
    at Gulp.<anonymous> (/Users/alex/dev/mist/gulpfile.js:284:16)
    at module.exports (/Users/alex/dev/mist/node_modules/orchestrator/lib/runTask.js:34:7)
    at Gulp.Orchestrator._runTask (/Users/alex/dev/mist/node_modules/orchestrator/index.js:273:3)
    at Gulp.Orchestrator._runStep (/Users/alex/dev/mist/node_modules/orchestrator/index.js:214:10)
    at /Users/alex/dev/mist/node_modules/orchestrator/index.js:279:18
    at finish (/Users/alex/dev/mist/node_modules/orchestrator/lib/runTask.js:21:8)
    at /Users/alex/dev/mist/node_modules/orchestrator/lib/runTask.js:52:4
    at f (/Users/alex/dev/mist/node_modules/once/once.js:17:25)
[20:12:19] 'mist' errored after 3.47 min
[20:12:19] Error in plugin 'run-sequence(copy-app-folder-files)'
Message:
    cp: /Users/alex/dev/mist/node_modules/webdriverio/node_modules/.bin/supports-color: No such file or directory

Stack:
    at finish (/Users/alex/dev/mist/node_modules/run-sequence/index.js:56:13)
    at Gulp.onError (/Users/alex/dev/mist/node_modules/run-sequence/index.js:67:4)
    at emitOne (events.js:101:20)
    at Gulp.emit (events.js:188:7)
    at Gulp.Orchestrator._emitTaskDone (/Users/alex/dev/mist/node_modules/orchestrator/index.js:264:8)
    at /Users/alex/dev/mist/node_modules/orchestrator/index.js:275:23
    at finish (/Users/alex/dev/mist/node_modules/orchestrator/lib/runTask.js:21:8)
    at cb (/Users/alex/dev/mist/node_modules/orchestrator/lib/runTask.js:29:3)
    at Gulp.<anonymous> (/Users/alex/dev/mist/gulpfile.js:284:16)
    at module.exports (/Users/alex/dev/mist/node_modules/orchestrator/lib/runTask.js:34:7)
    at Gulp.Orchestrator._runTask (/Users/alex/dev/mist/node_modules/orchestrator/index.js:273:3)
    at Gulp.Orchestrator._runStep (/Users/alex/dev/mist/node_modules/orchestrator/index.js:214:10)
    at /Users/alex/dev/mist/node_modules/orchestrator/index.js:279:18
    at finish (/Users/alex/dev/mist/node_modules/orchestrator/lib/runTask.js:21:8)
    at /Users/alex/dev/mist/node_modules/orchestrator/lib/runTask.js:52:4
    at f (/Users/alex/dev/mist/node_modules/once/once.js:17:25)

hiddentao · 2016-09-08T07:00:01Z

This PR is out of date now, I need to refactor it.

# Conflicts: # nodes/eth/mac-x64/libevmasm.dylib # nodes/eth/mac-x64/liblll.dylib # nodes/eth/mac-x64/libnatspec.dylib # nodes/eth/mac-x64/libsolidity.dylib # nodes/eth/mac-x64/libtestutils.dylib # nodes/eth/win-x64/eth.ilk # nodes/eth/win-x64/eth.pdb # nodes/eth/win-x64/msvcp120.dll # nodes/eth/win-x64/msvcr120.dll # package.json

hiddentao · 2016-09-08T08:13:59Z

Merged with develop and fixed some issues.

hiddentao · 2016-09-08T08:14:07Z

Also upgraded to Electron 1.3.5 as part of fix.

evertonfraga · 2016-09-14T03:57:49Z

When building from mac, make sure to:

have both node and npm up to date.
brew install mono
brew install graphicsmagick
brew install gnu-tar

After setting up, I managed to build everything. I'll test properly on all platforms and improve the DMG background.

@hiddentao question: what are those .nupkg generated on windows folders? I guess it's something related to VisualStudio development – so we'd better use the .exe, right?

hiddentao · 2016-09-15T05:16:20Z

@evertonfraga The .nupkg files are just intermediates, and can be ignored. Exe's are what you want.

lock · 2018-03-31T21:23:12Z

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

basic OS X build working

9df1a7e

hiddentao added the Status: In progress label Jul 15, 2016

hiddentao added this to the 0.8.2 milestone Jul 15, 2016

work towards multi-platform builds on osx

dd39013

luclu mentioned this pull request Jul 17, 2016

Improve Packaging and Distribution #561

Closed

19 tasks

hiddentao added 4 commits July 20, 2016 15:56

Merge remote-tracking branch 'mist/develop' into electron_builder

e2872b2

# Conflicts: # package.json

updated shrinkwrap

2aa44c7

fix electron prebuilt v

da1a86f

work towards fixing node path

7eaca8c

luclu reviewed Jul 20, 2016
View reviewed changes

npm-shrinkwrap.json

@@ -1,7 +1,17 @@

{

"name": "Mist",

"version": "0.8.0",

"version": "0.8.1",

Copy link

Contributor

luclu Jul 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

hiddentao added 5 commits July 21, 2016 13:40

console log

0f41ed4

fix node path for mac builds

4d79f40

fixed downloading and unzipping of nodes

a689264

remove decompressino plugin

da497d8

shift towards programmatic use of electron-builder

69d9b89

luclu mentioned this pull request Jul 25, 2016

change binary name "Ethereum-Wallet" to "Ethereum Wallet" #883

Closed

hiddentao modified the milestones: 0.8.3, 0.8.2 Jul 26, 2016

hiddentao self-assigned this Jul 26, 2016

hiddentao added 11 commits July 28, 2016 12:42

Merge branch 'develop' into electron_builder

0419a1f

# Conflicts: # gulpfile.js

dynamically fetch electron version

9f931b7

fix node downloads

56f3d07

remove redundant line

cd8022e

fix unzipping / rename nodes

835d739

fixes for platform node checking

f0c433f

fixed loading of node on windows

ced1de0

fix use of options.platform

aaca7a2

further fixes for use options.platform

a99c731

shrinkwrap

e11c75b

Merge remote-tracking branch 'mist/develop' into electron_builder

d03b29c

hiddentao added 2 commits August 3, 2016 14:17

get mac build working again

bff62a9

rename darwin to mac

511989a

fix build

ad6ee1e

hiddentao added Status: Please review and removed Status: In progress labels Aug 8, 2016

hiddentao added 3 commits August 8, 2016 13:50

updated README

a2906ca

more readme updates

d2ba3b0

Merge branch 'develop' into electron_builder

a88ad95

luclu mentioned this pull request Aug 20, 2016

check for system-wide installation of nodes; dynamically populate node-menu #1064

Closed

15 tasks

hiddentao added Status: In progress and removed Status: Please review labels Sep 8, 2016

fix build

b81a0ae

hiddentao added Status: Please review and removed Status: In progress labels Sep 8, 2016

evertonfraga mentioned this pull request Sep 14, 2016

Integrating electron-builder for better distributables building #1159

Merged

evertonfraga merged commit b81a0ae into ethereum:develop Sep 15, 2016

evertonfraga removed the Status: Please review label Sep 15, 2016

lock bot locked and limited conversation to collaborators Mar 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrating electron-builder for better distributables building #972

Integrating electron-builder for better distributables building #972

hiddentao commented Jul 15, 2016 •

edited

Loading

luclu Jul 20, 2016

hiddentao commented Aug 3, 2016

frozeman commented Aug 3, 2016

hiddentao commented Aug 3, 2016

hiddentao commented Aug 8, 2016

alexvandesande commented Sep 7, 2016

hiddentao commented Sep 8, 2016

hiddentao commented Sep 8, 2016

hiddentao commented Sep 8, 2016

evertonfraga commented Sep 14, 2016

hiddentao commented Sep 15, 2016

lock bot commented Mar 31, 2018

Integrating electron-builder for better distributables building #972

Integrating electron-builder for better distributables building #972

Conversation

hiddentao commented Jul 15, 2016 • edited Loading

luclu Jul 20, 2016

Choose a reason for hiding this comment

hiddentao commented Aug 3, 2016

frozeman commented Aug 3, 2016

hiddentao commented Aug 3, 2016

hiddentao commented Aug 8, 2016

alexvandesande commented Sep 7, 2016

hiddentao commented Sep 8, 2016

hiddentao commented Sep 8, 2016

hiddentao commented Sep 8, 2016

evertonfraga commented Sep 14, 2016

hiddentao commented Sep 15, 2016

lock bot commented Mar 31, 2018

hiddentao commented Jul 15, 2016 •

edited

Loading