Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template upgrade #123

Merged
merged 70 commits into from
Aug 18, 2022
Merged

Template upgrade #123

merged 70 commits into from
Aug 18, 2022

Conversation

carver
Copy link
Collaborator

@carver carver commented Aug 18, 2022 •
edited
Loading

What was wrong?

Fix #120
Fix #121

How was it fixed?

  • Followed the standard template-upgrade procedure.
  • Passed new style rules from pydocstyle, introduced during template upgrade.
  • Upgraded black manually, and passed new style rules.
  • Yaml tests aren't tested in CI, and seem to be failing. The yaml library is failing to build, and isn't used in CI anyway, so it was isolated to only the yaml test environment.

Cute Animal Picture

put a cute animal picture link inside the parentheses

carver and others added 30 commits January 15, 2019 16:06
@carver
Drop py3.5, add py3.7
caf9050
@carver
Merge pull request #19 from ethereum/drop-py35
66e6b7e 
Drop py3.5, add py3.7
@davesque
Add docstring checking with pydocstyle
dd74824
@davesque
Merge pull request #21 from davesque/pydocstyle
2fb32d2 
Add docstring checking with pydocstyle
@davesque
Remove attribution to specific person
de4bdf9
@davesque
Merge pull request #22 from davesque/updates
7bffe4b 
Remove attribution to specific person, update README
@davesque
Remove travis config
5f3e6b3
@davesque
Merge pull request #23 from davesque/travis
0b85056 
Remove travis config
@davesque
Update default author email
5e6dc29
@davesque
Merge pull request #24 from davesque/updates
3c1bbfe 
Update default author email
@cburgdorf
Add mypy support
720b2cf
@pipermerriam
switch to native pypy markdown support
84d2b22
@carver
Merge pull request #26 from pipermerriam/piper/update-to-native-pypy-…
81af1b6 
…markdown-support

switch to native pypy markdown support
@carver
Skip venv in template filler & print progress
dc9f04c
@carver
Add vim .swo files and .mypy_cache to .gitignore
a6f6078
@cburgdorf
Setup towncrier to generate release notes
02fe356
@carver @cburgdorf
Separate release-note build from release
07eecb5
@carver @cburgdorf
Add internal type for release notes
89363b2
@carver
Merge pull request #27 from ethereum/template-filler-venv
df429d2 
Skip venv in template filler & print progress
@njgheorghita
Add MANIFEST.in file
4ab4a01
@njgheorghita
Merge pull request #43 from ethereum/manifest-in
6dd194c 
Add MANIFEST.in file
@carver
Update MIT License to 2020
c8f686f
@carver
Replace web3 reference with <MODULE_NAME>
e6e6962 
Some hard-coded references to web3.py slipped through. Clearly this user path is not tested very often. In eth-abi, it still said EthereumAlarmClock X)
@carver
Update docs copyright to the year 2020
6d75c9a
@carver
Merge pull request #44 from ethereum/templatize-module-name-in-docs
582e9aa 
Replace web3 reference with <MODULE_NAME>
@pipermerriam
Update testing and lint deps
4195de3
@pipermerriam
Merge pull request #46 from pipermerriam/piper/update-testing-and-lin…
e38d234 
…t-deps

Update testing and lint deps
@carver
Better error if bump missing in make notes/release
c447735
@carver
Merge pull request #47 from carver/bump-missing-error
54c02fe 
Better error if bump missing in make notes/release
@carver
Update link to correct URL for release notes
ea7038b
carver and others added 28 commits January 19, 2021 16:14
@carver
Add supported OS's
8c7f30b 
Fixes ethereum/ethereum-python-project-template#37
@carver
Pin sphinx-rtd-theme to <v1
b7baeca 
Fixes ethereum/ethereum-python-project-template#36
@carver
Merge pull request #53 from ethereum/export-type-annotations
8206797 
Export type annotations to importing projects
@carver
Merge pull request #54 from carver/multifix
cbfedb6 
A bunch of little patches
@carver
Fix the type annotations export, adding py.typed
1410bcb 
Fixes ethereum/ethereum-python-project-template#30
@carver
Merge pull request #55 from carver/type-export-bugfix
0807940 
Fix the type annotations export, adding py.typed
@kclowes
Add python3.8 support
765b2e4
@kclowes
Add python 3.9 support
fcb5577
@kclowes
Add python 3.10 support
d21d582
@kclowes
Update pytest to support python 3.10, pin pytest-xdist, bump eth-util…
0649062 
…s to >=2,<3
@kclowes
Merge pull request #58 from kclowes/update-template
b88fcf3 
Update template
@carver
Show full explanation for pydocstyle failures
c6f13bf
@carver
Exclude huge and unnecessary venv*/ from dist
d3a5a3e 
See an example issue here:
ethereum/eth-account#150
@carver
Merge pull request #59 from ethereum/pydocstyle-explain
c4f23a4 
Show full explanation for pydocstyle failures
@kclowes
Add breaking change type to newsfragment (#61)
2e22e2d 
* Add breaking change type to newsfragment

* Move breaking-change -> breaking
@carver
Use prune instead of recursive-exclude for venv*
e2e1f9d 
Frankly not sure why recursive-exclude doesn't work here, but prune does, and that's good enough for me now. It's also probably preferable to only exclude venv* at the root, anyway.
@carver
Use updated CircleCI images
5e10046 
See https://discuss.circleci.com/t/legacy-convenience-image-deprecation/41034
@carver
Merge pull request #62 from ethereum/circleci-image-update
4533bf6 
Use updated CircleCI images
@carver
Upgrade towncrier to fix the duplicate title bug
cb112ef
@carver
Merge pull request #60 from ethereum/exclude-venv-from-dist
0144dd9 
Exclude huge and unnecessary venv*/ from dist
@carver
Merge pull request #63 from carver/towncrier-upgrade
7fd5078 
Upgrade towncrier to fix the duplicate title bug
@kclowes
Add a validate docs command (#64)
160c0fe
@carver
Merge template changes into project
f6da9b8
@carver
Fill any new template variable usages
caee078
@carver
Upgrade black, follow latest style rules
272b52a
@carver
Use updated pydocstyle rules
ced5c55
@carver
Ignore black reformatting commit
d57ffb1
@carver
Remove ruamel.yaml from all-test dependencies
2566117 
ruamel isn't building on python 3.9 or 3.10. Upgrading ruamel may fix
that, but the yaml tests don't seem to be passing anyway, and weren't
included in CI. So rather than try to dig in right now to fix them, just
push the dependency fix to whoever decides to revive the yaml tests.
@carver carver merged commit 378bc79 into master Aug 18, 2022
@carver carver deleted the template-upgrade branch August 18, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade the template Update black to the stable version, and auto-format
7 participants
@carver @davesque @cburgdorf @pipermerriam @njgheorghita @tmckenzie51 @kclowes