Adding python3.7 support #19
Conversation
|
This should be using CircleCI instead of adding a travis config. |
6ug
changed the title
|
Things I did -
@carver kindly review extra things and let me know, may be I can remove them upon suggestions. |
Makefile
Outdated
| @@ -22,7 +22,7 @@ clean-pyc: | |||
| find . -name '*~' -exec rm -f {} + | |||
|
|
|||
| lint: | |||
| flake8 py_ecc | |||
| flake8 --max-line-length=100 py_ecc | |||
There was a problem hiding this comment.
Instead, this can go in the tox.ini, like https://github.com/ethereum/ethereum-python-project-template/blob/03f00d3fbe73b0ea6bd46b5e5b4e9a4103ee0226/tox.ini#L17-L20
There was a problem hiding this comment.
yes @carver, then I like to go with earlier one, do you mind if I ignore it from commit?
There was a problem hiding this comment.
do you mind if I ignore it from commit?
Sorry, do you mean to rebase and force-push? That's totally fine. (preferred)
requirements-dev.txt
Outdated
| @@ -1,2 +1,3 @@ | |||
| pytest==3.2.2 | |||
| pytest-xdist==1.20.1 | |||
| flake8==3.5.0 | |||
There was a problem hiding this comment.
The flake8 dependency is in the py_ecc[lint] extra, we should be using that instead.
In fact, requirements-dev and any references to it should be removed entirely.
6ug
force-pushed
the
python37
branch
5 times, most recently
from
c44f113
to
b38a85c
Compare
Drop py3.5, add py3.7
Fixes #10
(PS. I need this PR to be get merge to proceed with my mypy hinting issue.)
Not able to apply from site due to it thrown me some bad API error.