Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP-8 #32

Merged
merged 5 commits into from
Feb 22, 2016
Merged

EIP-8 #32

merged 5 commits into from
Feb 22, 2016

Conversation

fjl
Copy link

@fjl fjl commented Jan 18, 2016

Implements ethereum/EIPs#49.

@fjl
Copy link
Author

fjl commented Jan 19, 2016

@ms83 I can't get full app tests to pass (see Travis output in this PR). Do they pass for you?

@panpilkarz
Copy link

Yes. https://travis-ci.org/ethereum/pydevp2p/pull_requests

@fjl fjl force-pushed the eip8 branch 2 times, most recently from 5a4d415 to 40cbde2 Compare January 19, 2016 10:54
@fjl
Copy link
Author

fjl commented Feb 9, 2016

Alright. We've decided to go forward with EIP-8, so this PR is now open for review.

I still can't get the full app tests to pass. I tried cherry picking the first few commits from #35 but it didn't help.

@fjl
Copy link
Author

fjl commented Feb 19, 2016

Rebased again. Tests work now (thanks @ulope).

You can test the RLPx handshake changes against go-ethereum by doing:

... start your node...

git clone --branch develop https://github.com/ethereum/go-ethereum
cd go-ethereum
make
RLPX_EIP8=yes ./build/bin/geth --bootnodes <your enode URL>

@heikoheiko
Copy link
Member

@fjl awesome! thank you!

@heikoheiko heikoheiko closed this Feb 19, 2016
@konradkonrad
Copy link

oops...?

@konradkonrad konradkonrad reopened this Feb 19, 2016
konradkonrad added a commit that referenced this pull request Feb 22, 2016
@konradkonrad
Merge pull request #32 from fjl/eip8
3b230c4 
EIP-8
@konradkonrad konradkonrad merged commit 3b230c4 into ethereum:develop Feb 22, 2016
ASISBusiness
ASISBusiness reviewed Jul 18, 2023
View reviewed changes
Copy link

@ASISBusiness ASISBusiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ASISBusiness ASISBusiness ASISBusiness left review comments

@GIgako19929 GIgako19929 GIgako19929 approved these changes

@St0nersdash St0nersdash St0nersdash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fjl @panpilkarz @heikoheiko @konradkonrad @ASISBusiness @St0nersdash @GIgako19929