EIP-8 #32
Merged
EIP-8 #32
+456
−139
Conversation
@ms83 I can't get full app tests to pass (see Travis output in this PR). Do they pass for you? |
Alright. We've decided to go forward with EIP-8, so this PR is now open for review. I still can't get the full app tests to pass. I tried cherry picking the first few commits from #35 but it didn't help. |
This is required because RLPxSession matches on RuntimeError to catch decryption failures.
Rebased again. Tests work now (thanks @ulope). You can test the RLPx handshake changes against go-ethereum by doing:
|
@fjl awesome! thank you! |
oops...? |
konradkonrad
added a commit
that referenced
this pull request
Feb 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Implements ethereum/EIPs#49.