Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-8 #32

Merged
merged 5 commits into from Feb 22, 2016
Merged

EIP-8 #32

merged 5 commits into from Feb 22, 2016

Conversation

@fjl
Copy link

@fjl fjl commented Jan 18, 2016

Implements ethereum/EIPs#49.

@fjl
Copy link
Author

@fjl fjl commented Jan 19, 2016

@ms83 I can't get full app tests to pass (see Travis output in this PR). Do they pass for you?

@fjl fjl force-pushed the fjl:eip8 branch 2 times, most recently from 5a4d415 to 40cbde2 Jan 19, 2016
@fjl fjl force-pushed the fjl:eip8 branch from bfad325 to a5ef807 Feb 9, 2016
@fjl
Copy link
Author

@fjl fjl commented Feb 9, 2016

Alright. We've decided to go forward with EIP-8, so this PR is now open for review.

I still can't get the full app tests to pass. I tried cherry picking the first few commits from #35 but it didn't help.

@fjl fjl force-pushed the fjl:eip8 branch from a5ef807 to ea0bd3e Feb 19, 2016
@fjl
Copy link
Author

@fjl fjl commented Feb 19, 2016

Rebased again. Tests work now (thanks @ulope).

You can test the RLPx handshake changes against go-ethereum by doing:

... start your node...

git clone --branch develop https://github.com/ethereum/go-ethereum
cd go-ethereum
make
RLPX_EIP8=yes ./build/bin/geth --bootnodes <your enode URL>
@heikoheiko
Copy link
Member

@heikoheiko heikoheiko commented Feb 19, 2016

@fjl awesome! thank you!

@heikoheiko heikoheiko closed this Feb 19, 2016
@konradkonrad
Copy link

@konradkonrad konradkonrad commented Feb 19, 2016

oops...?

@konradkonrad konradkonrad reopened this Feb 19, 2016
konradkonrad added a commit that referenced this pull request Feb 22, 2016
EIP-8
@konradkonrad konradkonrad merged commit 3b230c4 into ethereum:develop Feb 22, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+2.08%) to 88.426%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants