Skip to content
This repository has been archived by the owner on Mar 3, 2021. It is now read-only.

remix-debug depends on web3 #1180

Conversation

scottt
Copy link
Contributor

@scottt scottt commented May 7, 2019

remix-debug has the following line in src/cmdline/index.js:

var Web3 = require('web3')

<... snip ...>

  connect (providerType, url) {
    if (providerType !== 'http') throw new Error('unsupported provider type')
    this.web3 = new Web3(new Web3.providers.HttpProvider(url))
  }

So it should either mark web3 as a dependency in package.json or
refactor remix-lib to provide a web3 provider that can take an
url paramter.

This patch does the former and makes remix-debug depend on the same
version of web3 as remix-lib in package.json.

remix-debug has the following line in `src/cmdline/index.js`:
```
var Web3 = require('web3')

<... snip ...>

  connect (providerType, url) {
    if (providerType !== 'http') throw new Error('unsupported provider type')
    this.web3 = new Web3(new Web3.providers.HttpProvider(url))
  }

```

So it should either mark `web3` as a dependency in `package.json` or
refactor `remix-lib` to provide a web3 provider that can take an
`url` paramter.

This patch does the former and makes `remix-debug` depend on the same
version of `web3` as `remix-lib` in `package.json`.
@yann300 yann300 self-requested a review May 8, 2019 15:31
@yann300 yann300 merged commit 09acd17 into ethereum:master May 8, 2019
@scottt scottt deleted the package-json-remix-debug-depends-on-web3 branch June 20, 2019 18:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants