Add log emission tests #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwwhww
approved these changes
May 13, 2018
| mine(web3, 1) | ||
| # Check that log was successfully emitted | ||
| tx_receipt = web3.eth.getTransactionReceipt(tx_hash) | ||
| log = smc_handler.events.RegisterNotary().processReceipt(tx_receipt)[0]['args'] |
There was a problem hiding this comment.
Thinking if we need some APIs for those special logs (AddHeader, SubmitVote, RegisterNotary, DeregisterNotary, ReleaseNotary ...) in SMCHandler. What do you think of that?
There was a problem hiding this comment.
Yes. I was thinking adding these AIPs in ShardTracker.
shard_id in these events will be indexed so the logs emitted will become searchable(search by shard_id) and so clients using ShardTracker will get exactly the logs they care.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Add tests to make sure event logs are/fail to emitted as expected.
Cute Animal Picture