Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative versions of 0.4.15, 0.5.9, 0.5.11 from github release page #57

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

cameel
Copy link
Member

@cameel cameel commented Oct 5, 2020

This is the most important part of ethereum/solidity#7512. The PR adds releases from github for versions where the file in this repository was not actually built on the release tag.

Files were downloaded and renamed using my script from #41. The name is based on the commit associated with the tag and there's nothing preventing the file in the release from having been actually built on a different commit so I manually checked versions reported by the executables using solc-js. They all match the name:

File name Output from version()
soljson-v0.4.15+commit.8b45bddb.js 0.4.15+commit.8b45bddb.Emscripten.clang
soljson-v0.4.15+commit.bbb8e64f.js 0.4.15+commit.bbb8e64f.Emscripten.clang
soljson-v0.5.9+commit.c68bc34e.js 0.5.9+commit.c68bc34e.Emscripten.clang
soljson-v0.5.9+commit.e560f70d.js 0.5.9+commit.e560f70d.Emscripten.clang
soljson-v0.5.11+commit.22be8592.js 0.5.11+commit.22be8592.Emscripten.clang
soljson-v0.5.11+commit.c082d0b4.js 0.5.11+commit.c082d0b4.Emscripten.clang

… page

- These were actually built on the tagged commit. The ones in the repo now were built on the merge commit right after that.
@cameel cameel force-pushed the add-0.4.15-0.5.9-0.5.11-from-github branch from a6f7d95 to 6c9863e Compare October 6, 2020 09:47
@chriseth chriseth merged commit 05f9c50 into gh-pages Oct 7, 2020
@chriseth chriseth deleted the add-0.4.15-0.5.9-0.5.11-from-github branch October 7, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants