Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace linux 0.4.26 build with the binary from 0.4.26 docker image #80

Merged

Conversation

cameel
Copy link
Member

@cameel cameel commented Jan 28, 2021

Fixes ethereum/solidity#10840.
Depends on #76.
Depends on #91.

I'm not sure if we really want to solve ethereum/solidity#10840 this way but it's certainly one way to do this.
The binary from the 0.4.26 docker image produces different bytecode on the problematic test case and the asm version looks like the one produced by binaries for other platforms. I used it to replace the one currently in this repo. I'm creating this PR as a draft to see if it passes the comparison on all test cases.

If we want this then we should consider also replacing the binary on the github release page (it's identical to the one in solc-bin).

@cameel
Copy link
Member Author

cameel commented Jan 28, 2021

Reports are identical. Comparison actually failed but that's because of the macOs binary - I haven't based this PR on top of the one that has rebuilt macOS binaries. I'll rebase it now and the check should pass.

@cameel cameel force-pushed the replace-linux-0.4.26-build-with-binary-from-docker branch from 650a2a3 to fcc0109 Compare January 28, 2021 14:38
@cameel cameel changed the base branch from bytecode-comparison-pr-check to macosx-binaries-with-correct-version January 28, 2021 14:38
@cameel cameel force-pushed the replace-linux-0.4.26-build-with-binary-from-docker branch from fcc0109 to 478f690 Compare January 28, 2021 15:39
@chriseth
Copy link
Contributor

chriseth commented Feb 2, 2021

Is there a way to keep both binaries?

@cameel
Copy link
Member Author

cameel commented Feb 2, 2021

Not in a straightforward way. Both come from the same commit and version so there is a naming conflict. We'd have to break the naming convention or put it in a separate directory or get creative with naming (e.g. add a .js or .exe extension which would probably pass through most of our regexes in various scripts).

@chriseth
Copy link
Contributor

chriseth commented Feb 2, 2021

Ah sorry, I think I misunderstood. It is the linux binary that we only added some months ago, that is different, right? Then I don't think we need to keep the wrong version. And yes, I think we should also update one in the release.

@cameel
Copy link
Member Author

cameel commented Feb 2, 2021

Yes, it has been in solc-bin only for a few months. It's been on the github release page for a long time though.

@cameel cameel force-pushed the replace-linux-0.4.26-build-with-binary-from-docker branch from 478f690 to 589f1f9 Compare February 4, 2021 10:50
@cameel cameel marked this pull request as ready for review February 4, 2021 11:09
@cameel cameel force-pushed the macosx-binaries-with-correct-version branch from 20505ff to af2b12e Compare March 9, 2021 16:23
Base automatically changed from macosx-binaries-with-correct-version to gh-pages March 12, 2021 12:29
@cameel cameel force-pushed the replace-linux-0.4.26-build-with-binary-from-docker branch from 589f1f9 to 6673ca6 Compare March 12, 2021 16:57
@cameel cameel force-pushed the replace-linux-0.4.26-build-with-binary-from-docker branch from 6673ca6 to aa16da2 Compare May 10, 2021 12:58
@cameel cameel changed the base branch from gh-pages to use-correct-head-ref-in-bytecode-pr-check May 10, 2021 13:46
Base automatically changed from use-correct-head-ref-in-bytecode-pr-check to gh-pages May 10, 2021 14:25
@chriseth chriseth merged commit 765580c into gh-pages Jun 7, 2021
@chriseth chriseth deleted the replace-linux-0.4.26-build-with-binary-from-docker branch June 7, 2021 09:56
@axic
Copy link
Member

axic commented Jul 13, 2021

Did we end up releasing the blog post about these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linux binary for version 0.4.26 in solc-bin produces different bytecode than other platforms
3 participants