-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace linux 0.4.26 build with the binary from 0.4.26 docker image #80
Replace linux 0.4.26 build with the binary from 0.4.26 docker image #80
Conversation
Reports are identical. Comparison actually failed but that's because of the macOs binary - I haven't based this PR on top of the one that has rebuilt macOS binaries. I'll rebase it now and the check should pass. |
650a2a3
to
fcc0109
Compare
fcc0109
to
478f690
Compare
Is there a way to keep both binaries? |
Not in a straightforward way. Both come from the same commit and version so there is a naming conflict. We'd have to break the naming convention or put it in a separate directory or get creative with naming (e.g. add a |
Ah sorry, I think I misunderstood. It is the linux binary that we only added some months ago, that is different, right? Then I don't think we need to keep the wrong version. And yes, I think we should also update one in the release. |
Yes, it has been in |
478f690
to
589f1f9
Compare
20505ff
to
af2b12e
Compare
589f1f9
to
6673ca6
Compare
- The current binary produces slightly different optimized bytecode than binaries for other platforms on one of the test cases. - Image: https://hub.docker.com/layers/ethereum/solc/0.4.26/images/sha256-2e9558c26d9b8659e52fea33a6f744190c5ad9ac8a70e628097ab2fbdc30800e?context=explore
6673ca6
to
aa16da2
Compare
Did we end up releasing the blog post about these? |
Fixes ethereum/solidity#10840.
Depends on #76.Depends on #91.
I'm not sure if we really want to solve ethereum/solidity#10840 this way but it's certainly one way to do this.
The binary from the 0.4.26 docker image produces different bytecode on the problematic test case and the asm version looks like the one produced by binaries for other platforms. I used it to replace the one currently in this repo. I'm creating this PR as a draft to see if it passes the comparison on all test cases.
If we want this then we should consider also replacing the binary on the github release page (it's identical to the one in solc-bin).