Fix null dereference in using for directive when operator name is empty #14135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusaaguiar
changed the title
matheusaaguiar
force-pushed
the
fix_null_deref_using_for
branch
2 times, most recently
from
facbc74
to
9cf6479
Compare
| @@ -0,0 +1,3 @@ | |||
| using {f as ''} for uint; | |||
There was a problem hiding this comment.
I'd cover additional cases that Kamil mentioned in the original issue. Also, this error kinda looks a bit weird when an empty string is returned; perhaps we should consider a special case for this scenario (not necessarily in this PR, since I'd assume that a segfault takes precedence).
There was a problem hiding this comment.
Yes, I will add tests for those too.
I had the thought to make a different message for the case of the empty string, but stopped myself until we decide it is really needed. Also, I agree that it is probably better to (eventually) do it in another PR.
matheusaaguiar
force-pushed
the
fix_null_deref_using_for
branch
from
b44bd8c
to
e019a59
Compare
nikola-matic
previously approved these changes
Apr 18, 2023
cameel
reviewed
Apr 18, 2023
test/libsolidity/syntaxTests/operators/userDefined/using_for_empty_operator_name.sol
Outdated
Show resolved
Hide resolved
test/libsolidity/syntaxTests/operators/userDefined/using_for_empty_operator_name.sol
Outdated
Show resolved
Hide resolved
matheusaaguiar
force-pushed
the
fix_null_deref_using_for
branch
from
e019a59
to
5a24be3
Compare
matheusaaguiar
force-pushed
the
fix_null_deref_using_for
branch
from
5a24be3
to
64f57ac
Compare
|
Addressed all comments and rebased. |
ekpyron
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #14016 .