Force install python3.12 for Window bytecode compare job #14873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
nikola-matic
force-pushed
the
pin-python-in-windows-ci
branch
from
7b4ce62
to
c49d847
Compare
cameel
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
This sucks, but I guess it's still marginally better than just having a symlink that randomly breaks, so we can accept it as a temporary hotfix. At least this way we won't have to bump version each time they update the image.
In terms of timing it's not as bad as I expected. Seems to add ~15 sec to the running time, so we can live with it until a proper fix.
|
Rebase and merge :) |
Why rebase though, I can just merge it straight away, no? You hardhat PR's not been merged yet, right? |
As you wish :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.