SMTChecker: Fix error that reports invalid number of verified checks #15191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgebal
force-pushed
the
smtchecker/fix-invalid-number-of-verified-checks
branch
4 times, most recently
from
dc8fbc3
to
af02228
Compare
pgebal
commented
Jun 11, 2024
| @@ -149,7 +149,10 @@ class BMC: public SMTEncoder | |||
|
|
|||
| friend bool operator<(BMCVerificationTarget const& _a, BMCVerificationTarget const& _b) | |||
| { | |||
| return _a.expression->id() < _b.expression->id(); | |||
| if (_a.expression->id() == _b.expression->id()) | |||
There was a problem hiding this comment.
Here was the problem. We didn't accumulate more than 1 proved BMC target for a given expression.
blishko
requested changes
Jun 13, 2024
| @@ -149,7 +149,10 @@ class BMC: public SMTEncoder | |||
|
|
|||
| friend bool operator<(BMCVerificationTarget const& _a, BMCVerificationTarget const& _b) | |||
| { | |||
| return _a.expression->id() < _b.expression->id(); | |||
| if (_a.expression->id() == _b.expression->id()) | |||
… for BMC and CHC engines
pgebal
force-pushed
the
smtchecker/fix-invalid-number-of-verified-checks
branch
from
1eb00eb
to
48f97a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #15188 for BMC egine.