Skip to content

[SMTChecker] Keep track of current path conditions #3304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 18, 2017
Merged

[SMTChecker] Keep track of current path conditions #3304

merged 2 commits into from
Dec 18, 2017

Conversation

leonardoalt
Copy link

  • Added the implies operator to the SolverInterface.
  • Keeping track of the current path conditions.
  • Using the conjunction of the current path conditions as implicant for checks instead of pushing the solver. The solver is still pushed/popped for the check, but not for the condition scope.

chriseth
chriseth reviewed Dec 12, 2017
View reviewed changes
libsolidity/formal/SMTChecker.cpp Outdated

m_interface->push();
m_interface->addAssertion(expr(_condition));
m_interface->addAssertion(currentPathConditions() && expr(_condition));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a helper for m_interface->addAssertion(currentPathCondition() && x)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@chriseth chriseth merged commit 2e2f819 into argotorg:develop Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@chriseth chriseth chriseth approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leonardoalt @chriseth @LianaHus