Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement working address db #58

Closed
cgewecke opened this issue Feb 27, 2020 · 3 comments
Closed

Implement working address db #58

cgewecke opened this issue Feb 27, 2020 · 3 comments

Comments

@cgewecke
Copy link
Contributor

cgewecke commented Feb 27, 2020 •
edited by huly-for-github bot
Loading

Tracking issue for comment in #53

View in Huly HI-136
@cgewecke cgewecke mentioned this issue Feb 27, 2020
Merged
@cgewecke cgewecke mentioned this issue Mar 24, 2020
Merged
@cgewecke
Copy link
Contributor Author

cgewecke commented Mar 24, 2020 •
edited
Loading

NB: both the injector and react UI currently require an address input for all chains. The addressDB is meant to make this optional for mainnet. When it's wired in, changes to enable this are:

  • In ui/App.js: revert 7c8181c
  • In src/injector.ts: validateAddresses made less strict.

@edisinovcic
Copy link
Contributor

Would it make sense to use same database for this and creation bytecode?

#111

@edisinovcic edisinovcic assigned DeFiYaco and unassigned DeFiYaco Dec 14, 2020
@edisinovcic
Copy link
Contributor

Addressed here: #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cgewecke @edisinovcic @DeFiYaco