Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript #53

Merged
merged 19 commits into from
Feb 27, 2020
Merged

Add typescript #53

merged 19 commits into from
Feb 27, 2020

Conversation

cgewecke
Copy link
Contributor

@cgewecke cgewecke commented Feb 17, 2020

#36 Typescript

  • Migrates the main application files to typescript using a permissive tsconfig which allows javascript. Test files, ui and js scripts remain in js.
  • Adds tslint step to CI
  • All the types / ts dependencies are added as dev deps. Did this on assumption that project will be published as a docker. tsc is run during the docker initialization & the application consumes its code as transpiled JS from thedist/ folder.
  • Unit tests are run using ts-node, directly from ./src

Running:

docker-compose -f docker-compose-testing.yaml up --build

...launches a server available at localhost:1234 and a local ganache instance with deployed contracts that can be used for manual testing. Docker output including contract addresses is visible in the terminal.

View in Huly HI-1179

docker-compose-testing.yaml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
src/injector.ts Outdated Show resolved Hide resolved
src/injector.ts Outdated Show resolved Hide resolved
@cgewecke
Copy link
Contributor Author

@edisinovcic This is all rebased and should be ready for a final look through I guess...

@cgewecke
Copy link
Contributor Author

Rebased for #57 via #45

@cgewecke cgewecke changed the base branch from repo-reorg to staging February 27, 2020 00:09
@cgewecke
Copy link
Contributor Author

@edisinovcic I'm merging this to staging per gitter conversation but it that's not what you intended we can always revert :)

@cgewecke cgewecke merged commit 0b3a794 into staging Feb 27, 2020
@edisinovcic edisinovcic deleted the typescript-initial branch July 27, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants