-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typescript #53
Merged
Merged
Add typescript #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgewecke
force-pushed
the
typescript-initial
branch
from
February 20, 2020 22:56
12a0ba4
to
0c66a23
Compare
cgewecke
commented
Feb 20, 2020
cgewecke
commented
Feb 20, 2020
edisinovcic
reviewed
Feb 21, 2020
cgewecke
commented
Feb 21, 2020
cgewecke
commented
Feb 21, 2020
cgewecke
force-pushed
the
typescript-initial
branch
from
February 25, 2020 00:40
984720c
to
0b28c2a
Compare
@edisinovcic This is all rebased and should be ready for a final look through I guess... |
cgewecke
force-pushed
the
typescript-initial
branch
from
February 26, 2020 18:48
b380d7e
to
d1882b1
Compare
@edisinovcic I'm merging this to staging per gitter conversation but it that's not what you intended we can always revert :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#36 Typescript
tsc
is run during the docker initialization & the application consumes its code as transpiled JS from thedist/
folder../src
Running:
...launches a server available at
localhost:1234
and a local ganache instance with deployed contracts that can be used for manual testing. Docker output including contract addresses is visible in the terminal.View in Huly HI-1179