Fix filename collusion #1582
Merged
Fix filename collusion #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e name Found in the [failin CI chain test (6119)](https://app.circleci.com/pipelines/github/ethereum/sourcify/6708/workflows/691eabb9-fba5-4a94-a762-a9344bc32471/jobs/40656), where it was unexpectedly fetching files from IPFS when the files are already provided. Turns out when there are files with the same name, the files get overwritten by the `readFilesRecursively` function. Fixed by using a relative path as the key in the `files` object. Also adds a log line to debug easier missing files when checking contracts
kuzdogan
force-pushed
the
fix-filename-collusion
branch
from
6a74c65
to
6484610
Compare
|
Yes baseDirectory is only passed in recursive calls. The reason I used a relativePath was to make it nicer, as |
marcocastignoli
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in the failin CI chain test (6119), where it was unexpectedly fetching files from IPFS when the files are already provided.
Turns out when there are files with the same name, the files get overwritten by the
readFilesRecursivelyfunction. Fixed by using a relative path as the key in thefilesobject.Also adds a log line to debug easier missing files when checking contracts