Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Velas Mainnet #559

Merged
merged 6 commits into from
Nov 22, 2021
Merged

Added Velas Mainnet #559

merged 6 commits into from
Nov 22, 2021

Conversation

roman-tik
Copy link
Contributor

@roman-tik roman-tik commented Oct 13, 2021

View in Huly HI-970

@kuzdogan
Copy link
Member

As stated in the readme, can you please provide a test contract and metadata

@roman-tik
Copy link
Contributor Author

roman-tik commented Oct 13, 2021

Contract: 0xd8A08AFf1B0585Cad0E173Ce0E93551Ac59D3530
Explorer + Verified Source: https://evmexplorer.velas.com/address/0xd8A08AFf1B0585Cad0E173Ce0E93551Ac59D3530/contracts
Metadata: MetaCoin.json.txt
Source: MetaCoin.sol.txt

@ogwurujohnson
Copy link
Member

ogwurujohnson commented Oct 15, 2021

Please can you confirm if Velas is listed in chain.json, cant seem to find it. If not, can you please get it listed, then we can proceed with this PR

@roman-tik
Copy link
Contributor Author

Now it is.
ethereum-lists/chains#484
@ogwurujohnson
thx

@roman-tik
Copy link
Contributor Author

is there anything else needed?

@kuzdogan
Copy link
Member

We were able to look into this just now, sorry for the delay.

Are the files flattened? I see the metadata file has two sources with below hashes but the provided source has a contract and a library:

sources: {
  "/Users/r/tmp/MetaCoin/contracts/ConvertLib.sol": {
    keccak256: "0x802fb99ec5d0aa49c37809e653d97c7d922951eaa400ff3ce81f665e77a38df7",
    urls: [
      "bzz-raw://c39ac4ab0ec6424a1fe00f06001482054cacda893e98501db20a44087bc559ae",
      "dweb:/ipfs/QmV5cuS3oyBBGY9SZNobTVnTYwAkWFtBQQdd1fE9zDerLP",
    ],
  },
  "/Users/r/tmp/MetaCoin/contracts/MetaCoin.sol": {
    keccak256: "0x7e34627c61102ed6c881136775155d892d8ea11f44891af74381211341c6b560",
    urls: [
      "bzz-raw://e1ab127705f908b0d89313501331b058cd5b4ecb6f26fb957efe55f07f07c12d",
      "dweb:/ipfs/Qmf6CDTRJrW8Tx9khPdBQv44isC2HGtcr5W4cw6DQmR8J7",
    ],
  },
}

Unlike Etherscan the source files are not to be flattened in Sourcify and each one described under sources is matched with the hash in the metadata. Can you please provide the files separately as they were compiled?

@kuzdogan kuzdogan merged commit 910ee08 into ethereum:staging Nov 22, 2021
@kuzdogan
Copy link
Member

The PR was automatically closed with the latest changes but the changes are not merged into our repository. I seem to have messed up a bit. Sorry for the confusion @roman-tik.

@roman-tik
Copy link
Contributor Author

@kuzdogan ok, but do you still need the sources?

@roman-tik
Copy link
Contributor Author

anyway, here are non flattened ones

ConvertLib.sol.txt
MetaCoin.sol.txt
Migrations.sol.txt

@kuzdogan
Copy link
Member

kuzdogan commented Dec 2, 2021

Merged with 26d401d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants