Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Fix ordering of p2p.abc module #834

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Fix ordering of p2p.abc module #834

merged 1 commit into from
Jul 25, 2019

Conversation

pipermerriam
Copy link
Member

@pipermerriam pipermerriam commented Jul 24, 2019 •
edited
Loading

What was wrong?

The p2p.abc module had the ProtocolAPI before the TransportAPI which was opposite.

How was it fixed?

Swapped the order of these being defined.

Also removed the __repr__ implementation on AddressAPI which should not have been present.

To-Do

  • Clean up commit history

Cute Animal Picture

16-10-14 Honeysuckle (7)C1000

@pipermerriam pipermerriam mentioned this pull request Jul 24, 2019
Merged
2 tasks
carver
carver approved these changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@carver carver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pipermerriam pipermerriam merged commit 9721bfe into ethereum:master Jul 25, 2019
@pipermerriam pipermerriam deleted the piper/abc-module-ordering branch July 25, 2019 16:35
@carver carver mentioned this pull request Aug 29, 2019
Closed
42 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carver carver carver approved these changes

@cburgdorf cburgdorf Awaiting requested review from cburgdorf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pipermerriam @carver