Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Relocate bcc_libp2p/factories.py #840

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Relocate bcc_libp2p/factories.py #840

merged 1 commit into from
Jul 25, 2019

Conversation

mhchia
Copy link
Contributor

@mhchia mhchia commented Jul 25, 2019 •
edited
Loading

What was wrong?

Fixes #833.

How was it fixed?

trinity/protocol/bcc_libp2p/factories.py is moved to trinity/tools/factories.py.

Cute Animal Picture

put a cute animal picture link inside the parentheses

@mhchia
Relocate bcc_libp2p/factories.py
09a8296 
trinity/protocol/bcc_libp2p/factories.py -> trinity/tools/factories.py
@mhchia mhchia requested a review from pipermerriam July 25, 2019 04:37
@mhchia mhchia mentioned this pull request Jul 25, 2019
Closed
pipermerriam
pipermerriam approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@pipermerriam pipermerriam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much appreciated 😄

@mhchia mhchia merged commit ff978d8 into ethereum:master Jul 25, 2019
@mhchia mhchia deleted the fix/relocate-libp2p-factories branch July 25, 2019 04:57
@carver carver mentioned this pull request Aug 29, 2019
Closed
42 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pipermerriam pipermerriam pipermerriam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

factory should not be under the main trinity code namespace.
2 participants
@mhchia @pipermerriam