Do not allow conversion from bytes array > 32 to int128 at compile time #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2018
Closed
jacqueswww
approved these changes
Nov 15, 2018
jacqueswww
approved these changes
Nov 27, 2018
vyper/types/convert.py
Outdated
| in_node = args[0] | ||
| typ, len = get_type(in_node) | ||
| if typ in ('uint256', 'bytes32'): | ||
| input_type, len = get_type(in_node) |
There was a problem hiding this comment.
Just change len to underscore and we can merge ;)
There was a problem hiding this comment.
@jacqueswww done! 🙌 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Related somewhat to conversation on #1082. Catch at compile-time if trying to convert
bytesarray of max length greater than 32 toint128type.- How I did it
Updated
convert.pyto do a check on max length when converting from bytes type (my understanding as to whySizeLimits.in_bounds()doesn't work forbytestype is that it is being passed by reference not by value?).Added relevant tests to
test_int128.py- How to verify it
make test- Description for the changelog
Patch to prevent conversion from bytes array greater than 32 bytes to int128.
- Cute Animal Picture