Remove old geth versions #1709
Merged
Remove old geth versions #1709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kclowes
force-pushed
the
remove-old-geth-versions
branch
from
6424633 to
a59b358
Compare
wolovim
approved these changes
Aug 17, 2020
| @@ -121,3 +121,6 @@ fabric.properties | |||
|
|
|||
| # pip wheel metadata | |||
| pip-wheel-metadata/ | |||
|
|
|||
| # jupyter notebook files | |||
| *.ipynb | |||
| @@ -73,7 +73,7 @@ | |||
| "eth-account>=0.5.2,<0.6.0", | |||
| "eth-hash[pycryptodome]>=0.2.0,<1.0.0", | |||
| "eth-typing>=2.0.0,<3.0.0", | |||
| "eth-utils>=1.8.4,<2.0.0", | |||
| "eth-utils>=1.8.4,<1.9.1", | |||
There was a problem hiding this comment.
FYI: the revert message work will require a later eth-utils version. Without it, EthereumTesterProvider won't receive revert messages. Can be figured out later.
| assert version == '5.0' | ||
| else: | ||
| assert version == '6.0' | ||
| assert version == '6.0' |
There was a problem hiding this comment.
FYI - latest version(s) of Geth removed Whisper from the distro, so when we bump to the latest version, maybe we want to look at dropping support for it in Web3.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
We decided we didn't need to support Geth versions past the most recent hard fork, since the Geth team doesn't support anything beyond the latest version.
Related to Issue #1703
How was it fixed?
Removed all old Geth tests and fixtures.
Todo:
Cute Animal Picture