Fix bug with async_lock implementation
#2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
async-cache-bug-hotfix
branch
from
87c5900
to
8a7af21
Compare
| inner.cancel() | ||
|
|
||
| outer = asyncio.create_task(_utilize_async_lock()) | ||
| await outer |
There was a problem hiding this comment.
It might be better to replace this line with await asyncio.wait_for(outer, 2) which will raise an asyncio.TimeoutError if outer takes more than 2 more seconds to execute. That way we'll get a failed test rather than a hang if there's a future bug with the lock.
There was a problem hiding this comment.
👍🏼 good point. I actually tweaked the timeouts quite a bit to make the test faster in general.
fselmo
force-pushed
the
async-cache-bug-hotfix
branch
2 times, most recently
from
fe78025
to
dc84582
Compare
- ``async_lock`` would hold onto the lock even if a task had been cancelled. This change ensures that the lock will be released if an exception is thrown during ``loop.run_in_executor()``.
fselmo
force-pushed
the
async-cache-bug-hotfix
branch
from
dc84582
to
3ecd6e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
closes #2693
How was it fixed?
async_lockif something goes wrong during a task.Todo:
Cute Animal Picture