-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ENS Resolver ABI #2700
Update ENS Resolver ABI #2700
Conversation
- rename ``RESOLVER`` constant to ``PUBLIC_RESOLVER_2`` to better clarify what ABI we are trying to use as default
Thanks @Snedashkovsky so much for the work here. This was needing some love. And sorry for the delay getting here. I don't feel great about adding in the I feel like this is a nice default and users can always customize and set a different ABI for their resolver if they have one to load. Any thoughts there? I rebased as well since the tests were failing 👀 |
@fselmo thank you for the PR update! |
What was wrong?
Deprecated Resolver ABI
Related to Issue #1839, #1397
How was it fixed?
@Snedashkovsky
@fselmo
renounceOwnership()
available without the proper documentation and the proper UX, with aliased methods that are clear on what they do.Todo:
Cute Animal Picture