-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace eth-abi deprecated method usage with supported methods #2726
Conversation
901dd12
to
533e35c
Compare
- These changes have been made in ``master`` but ``v5`` warnings throughout the library should be silenced as they interfere with user experience. This closes ethereum#2725.
533e35c
to
c87f820
Compare
- This version includes refactors for using supported ``eth-abi`` methods over the deprecated encode / decode methods.
6bf8314
to
f01ef7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Seems like this broke some stuff in our contract calls @pacrob @fselmo
|
@ahmetavc Ah, I think we still have too low of a lower bound for |
What was wrong?
closes #2725
v6
but need to be updated inv5
.How was it fixed?
eth-abi
methods internally with supported methods to silence warnings.eth-tester
for non-breaking changes there since I saw theeth-tester
tests withpy-evm
backend were still giving these warnings in one or two places. Cherry picked an earliereth-tester
branch, releasedv0.6.0-beta.7
, and pulled that in here so now the messages should not be there even througheth-tester
withpy-evm
backend tests.Todo:
Cute Animal Picture