-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update black
command to use regex pattern
#2727
Conversation
340b9eb
to
aa65da8
Compare
Could you add a link to your reference? Thanks! |
Clicking the
|
@pacrob come to think of it, we could probably just use
Any preference between the two? |
Slight preference for the latter |
Same. I'll update the commit. |
- Use regex pattern for ``black`` cli command via ``tox``. This fixes issues that I was experiencing locally and seems to be the recommended way of using the ``--exclude`` flag.
aa65da8
to
a471017
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
- Due to similar issues as was happening in ethereum#2727, ``mypy`` looks for regular expressions which led to issues running ``make lint`` locally.
- Due to similar issues as was happening in ethereum#2727, ``mypy`` looks for regular expressions which led to issues running ``make lint`` locally.
- Due to similar issues as was happening in #2727, ``mypy`` looks for regular expressions which led to issues running ``make lint`` locally.
What was wrong?
black
locally viatox
ormake lint
has never really worked for me. This regex way to set up theblack
command viatox
seems to work a bit better locally and regex seems to be the recommended way to run the command.Todo:
Cute Animal Picture