Properly handle eth-tester exception messages #2783
Conversation
web3/providers/eth_tester/main.py
Outdated
| raw_error_msg = ( | ||
| first_arg if not isinstance(first_arg, Exception) else first_arg.args[0] | ||
| ) | ||
| reason = abi.decode(["string"], raw_error_msg[4:])[0] |
There was a problem hiding this comment.
The biggest change, since this refactor doesn't show it too well, is this line. Parentheses removed here:
["(string)"] -> ["string"]
fselmo
force-pushed
the
fix-eth-tester-exception-message-parsing
branch
3 times, most recently
from
aa194b4
to
c8dc81b
Compare
| raw_error_msg = ( | ||
| first_arg if not isinstance(first_arg, Exception) else first_arg.args[0] | ||
| ) | ||
| reason = ( |
There was a problem hiding this comment.
Also new... if the reason is bytes, decode as string, else use the raw message. Previously, we just assumed it was bytes which is probably always true... but this is an added check.
| first_arg = e.args[0] | ||
| try: | ||
| # sometimes eth-tester wraps an exception in another exception | ||
| raw_error_msg = ( |
There was a problem hiding this comment.
In case eth-tester isn't wrapping one exception in another... check to see if we have a wrapped exception, otherwise take the first arg as the raw error message. This was previously vaguely handled by catching an AttributeError.
- After switching to ``abi.encode()```, ``eth-tester`` messages were not properly decoded
fselmo
force-pushed
the
fix-eth-tester-exception-message-parsing
branch
from
76724e9
to
2d65236
Compare
Yeah, specifically here. I wonder if it was originally done to catch just one type of general exception from |
What was wrong?
abi.encode()across the code base, someeth-testermessages were not properly decoded.context:
eth-testerwraps some exceptions in other exceptions. This parsing needs to be accounted for as it was broken when we switched frometh-abi'sencode_singletoabi.encode.How was it fixed?
Properly parse encoded messages from wrapped exceptions coming from
eth-testerTodo:
Cute Animal Picture