Replaced all public address #2785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't include arbitrary addresses in documentation. ethereum#2011 fixed almost all arbitrary addresses that may be matching with real public addresses.
|
@fselmo please review the pr. If there are any need for changes guide me. |
|
@2pushkaraj3 we appreciate your contribution and apologies that this became stale now with #2594 being merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't include arbitrary addresses in the documentation. #2011
What was wrong?
the arbitrary address matched with a real public address
Related to Issue #
How was it fixed?
by replacing all arbitrary addresses with public_address,sender_address