Add tracing methods again

[Uxio0]

What was wrong?

Closes #2830

How was it fixed?

Add tracing methods again

Todo:

• Add entry to the release notes

Cute animal picture

[kclowes]

Thanks @Uxio0! We're doing a code freeze for v6 while we test out this last beta version, but will get this in as soon as we're stable. We're hoping we'll be able to release stable next week, but it depends on what sorts of bugs we find in the next few days.

[Uxio0]

Sounds good, thanks @kclowes

[fselmo]

Thanks @Uxio0. I agree these are useful and it sits much nicer in a tracing module. v6 is out now so this can probably start inching its way back in. I just made a quick pass and added some general cleanup notes / nits. Would be good to add some tests before we merge this in. @kclowes I can try to contribute here this week and see if we can pull some from the old Parity module code (though that might take a bit to set up proper tests).

[Uxio0]

Thanks @Uxio0. I agree these are useful and it sits much nicer in a tracing module. v6 is out now so this can probably start inching its way back in. I just made a quick pass and added some general cleanup notes / nits. Would be good to add some tests before we merge this in. @kclowes I can try to contribute here this week and see if we can pull some from the old Parity module code (though that might take a bit to set up proper tests).

Hi @fselmo , thanks for your review. I've fixed the issues you reported.

Regarding testing, I couldn't find any previous tests for this

[fselmo]

Regarding testing, I couldn't find any previous tests for this

Yeah at some point we had a fairly convoluted parity test fixture that was removed likely before all this got removed. I wonder if we had some related tests there but it wouldn't make much sense to bring it back in that same way. I'll try to think of a lightweight way we can add a test here to know if something breaks or not.

@kclowes and I were thinking that for now we might just want to manually test all the methods, merge it in if it looks good, and create an issue to track the testing for the tracing module 🤔.

[Uxio0]

@kclowes and I were thinking that for now we might just want to manually test all the methods, merge it in if it looks good, and create an issue to track the testing for the tracing module 🤔.

Looks good to me

[fselmo]

rebased with master and force pushed... adding some formatters to these methods for human-readable values and re-testing

[fselmo]

@kclowes @pacrob @Uxio0 I added formatters to these methods and tested all but the trace_rawTransaction but it looks like the output (here) is similar to trace_call (here) so I think we should be good there. Ready for final review. Bookkeeping issue created to add some tests for the tracing module (#2894).

[pacrob]

lgtm!

[kclowes]

@Uxio0 This has been released in v6.1.0. Thanks again!

[Uxio0]

Awesome, thank you very much!