Add async eth.sign_typed_data #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3243eric
force-pushed
the
async-sign_typed_data
branch
3 times, most recently
from
705601b
to
d6fe73f
Compare
e3243eric
force-pushed
the
async-sign_typed_data
branch
2 times, most recently
from
5d1d8d0
to
853e116
Compare
e3243eric
force-pushed
the
async-sign_typed_data
branch
from
853e116
to
37d09fb
Compare
|
Looks good @e3243eric ! Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Related to Issue #2828. The
sign_typed_datamethod is unavailable on theAsyncEthclass.How was it fixed?
Adds the
sign_typed_datamethod to theAsyncEthclass, and adds corresponding tests.Closes #2828
Closes #2829
Todo:
Cute Animal Picture