Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clique small fixes / follow-up work #1074

Merged
merged 9 commits into from
Feb 5, 2021
Merged

Clique small fixes / follow-up work #1074

merged 9 commits into from
Feb 5, 2021

Commits on Feb 4, 2021

  1. add block option: cliqueSigner

    @ryanio
    ryanio committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    b0dee27 View commit details
    Browse the repository at this point in the history

  2. exactly compare checkpointSigners list with activeSigners list

    @ryanio
    ryanio committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    38b28cc View commit details
    Browse the repository at this point in the history

  3. * keep signer states and votes for `CLIQUE_SIGNER_HISTORY_BLOCK_LIMIT… 

    …` as number of blocks, not number of array entries

* don't reset votes on epoch blocks to keep in case of reorgs, but only count in `cliqueUpdateVotes()` if blockNumber >= last epoch block
    @ryanio
    ryanio committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    7ff5b16 View commit details
    Browse the repository at this point in the history

  4. ensure extraDataWithoutSeal has a minimum length of 32 bytes

    @ryanio
    ryanio committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    81dbd8d View commit details
    Browse the repository at this point in the history

  5. * in trimming signer states, always keep at least one item on the stack 

    * in trimming signer votes, keep votes until `lastEpochBlockNumber - CLIQUE_SIGNER_HISTORY_BLOCK_LIMIT` (as a safe number for potential recounts on reorgs)
    @ryanio
    ryanio committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    c0f81de View commit details
    Browse the repository at this point in the history

  6. explicitly check for blockchain.cliqueActiveSigners() in `BlockHead… 

    …er.validateCliqueDifficulty()`
    @ryanio
    ryanio committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    52cc5fb View commit details
    Browse the repository at this point in the history

  7. improve BlockHeader.validate typedoc

    @ryanio
    ryanio committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    11689d0 View commit details
    Browse the repository at this point in the history

  8. upgrade ethereumjs-util to v7.0.8 and use new Address.equals(address)… 

    … method
    @ryanio
    ryanio committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    9db72c2 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. Merge branch 'master' into clique-small-fixes

    @holgerd77
    holgerd77 authored Feb 5, 2021
    Configuration menu
    Copy the full SHA
    8f09e8a View commit details
    Browse the repository at this point in the history