Remove blockchain from stateManager #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think on a first look this makes a lot of sense. @holgerd77 @vpulim any comments? |
|
Looks great to me. I'm a big fan of simplifying the StateManager interface. |
|
@holgerd77 Yes, code changes LGTM. There is a possibility this breaks upstream dependencies that access stateManager.blockchain directly so maybe make this clear in the release notes or elsewhere? |
holgerd77
force-pushed
the
remove-blockchain-from-statemanager
branch
from
57ce17c to
3508ce0
Compare
|
Hi Matthew @mattdean-digicatapult, rebased this for (your 😄) convenience, if you prefer to always do this yourself let me know for next time. |
|
np @holgerd77, thanks for doing the rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the broader discussion in #268 and #309 so readers should probably start there.
The basic premise is that
getBlockHashshould not be onstateManager. This is the only block property that is present onstateManagerand it doesn't really fit. Removing this also means the ctor doesn't need to take a blockchain which simplifies the interface as per #268.