Skip to content

Update Old Readme Example #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 23, 2019
Merged

Update Old Readme Example #642

merged 2 commits into from
Dec 23, 2019

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented Dec 22, 2019

This PR updates an outdated example of how to build the library for use in browsers.

@github-actions
Copy link

Coverage Status

Coverage remained the same at 95.358% when pulling 4de032b on updateReadmeBrowser into cfb5d89 on master.

holgerd77
holgerd77 approved these changes Dec 23, 2019
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (I think we DO should really take 2 more state tests out 😄, this is a bit too tough burden on a smooth workflow, just realized here. Should be fine if an extended suite is run in nightly mode).

@holgerd77 holgerd77 merged commit 1ed9a9c into master Dec 23, 2019
@holgerd77 holgerd77 deleted the updateReadmeBrowser branch December 23, 2019 18:38
@evertonfraga evertonfraga added this to the VM v5 milestone Jun 12, 2020
This was referenced Aug 7, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: vm
Projects
None yet
Milestone
VM v5
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanio @holgerd77 @evertonfraga