Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

chore: update async and readable-stream dependencies #60

Merged

Conversation

alanshaw
Copy link

Ran tests and they all still pass \o/

Ran tests and they all still pass \o/
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.437% when pulling a53c0bd on alanshaw:chore/update-async-readable-stream into 3b96e3a on ethereumjs:master.

@holgerd77
Copy link
Member

Thanks a lot! Just out of curiosity (dependency updates are always welcome and useful, let alone for security reasons): does this come with some concrete advantages respectively did you have a reason for updating this specific dependencies?

@alanshaw
Copy link
Author

No problem - updating these will reduce the browser bundle size for ipfs.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR!

@holgerd77 holgerd77 merged commit e6c8107 into ethereumjs:master Nov 26, 2018
@alanshaw alanshaw deleted the chore/update-async-readable-stream branch November 29, 2018 10:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants