Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract tests in /modules to run with Bee class as well #38

Closed
vojtechsimetka opened this issue Dec 11, 2020 · 1 comment
Closed

Abstract tests in /modules to run with Bee class as well #38

vojtechsimetka opened this issue Dec 11, 2020 · 1 comment
Labels

Comments

@vojtechsimetka
Copy link
Contributor

Tension:
Right now we are unnecessarily replicating tests in the Bee class that are already in the individual modules

Proposed solution:
Abstract the tests so that they can be run on both the Bee class and the module. Good example how this can be done is https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/test/token/ERC777/ERC777.test.js#L43-L59

See discussion #15 (comment)

@vojtechsimetka
Copy link
Contributor Author

On the testing meeting on March 7th 2021 we decided we do not need to run the tests against both Bee class and individual modules. We will only run the tests for the functionality against the modules themselves (just as we do right now) and then test the bee class only for the assertion of params #248 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant