Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: replaced getPssPublicKey with getNodeAddresses #228

Merged
merged 1 commit into from
Mar 29, 2021
Merged

feat!: replaced getPssPublicKey with getNodeAddresses #228

merged 1 commit into from
Mar 29, 2021

Conversation

vojtechsimetka
Copy link
Contributor

No description provided.

@vojtechsimetka vojtechsimetka requested a review from a team March 25, 2021 14:03
agazso
agazso reviewed Mar 25, 2021
View reviewed changes
Copy link
Member

@agazso agazso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that there were no prior tests (and it's my fault 😅 ), but maybe it would be a good idea to add tests, at least when we introduce breaking changes.

@vojtechsimetka
Copy link
Contributor Author

@agazso This brings us again to the discussion of having tests that run against both the modules and the Bee/BeeDebug class itself #38 . Because we do test this function in the module :) https://github.com/ethersphere/bee-js/blob/master/test/modules/debug/connectivity.spec.ts#L54-L62

AuHau
AuHau approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@AuHau AuHau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vojtechsimetka vojtechsimetka merged commit 2932725 into master Mar 29, 2021
@vojtechsimetka vojtechsimetka deleted the feat/unify-address-method branch March 29, 2021 09:56
@bee-worker bee-worker mentioned this pull request Mar 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nugaon nugaon nugaon approved these changes

@AuHau AuHau AuHau approved these changes

@agazso agazso Awaiting requested review from agazso

Assignees
No one assigned
Labels
type:pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vojtechsimetka @agazso @AuHau @nugaon